[libvirt] [PATCH v2 3/3] qemu: Narrow the shutdown reconnection failure reason window

Michal Privoznik mprivozn at redhat.com
Tue Nov 6 09:38:16 UTC 2018


On 11/01/2018 05:04 PM, John Ferlan wrote:
> The current qemuProcessReconnect logic paints a broad brush
> determining that the shutdown reason must be crashed if it was
> determined that the domain was started with -no-shutdown; however,
> there's many other ways to get to the error label, so let's narrow
> our reasoning window for using VIR_DOMAIN_SHUTOFF_CRASHED to the
> period where we essentially know we've tried to create to the
> monitor and before we were successful in opening the connection.
> 
> Failures that occur outside that window would thus be considered
> as VIR_DOMAIN_SHUTOFF_UNKNOWN, at least for now.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/qemu/qemu_process.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

ACK

Michal




More information about the libvir-list mailing list