[libvirt] [PATCH RFC 22/22] qemu_process: Stop locking QMP process monitor immediately

Chris Venteicher cventeic at redhat.com
Sun Nov 11 19:59:30 UTC 2018


Locking the monitor object immediately after call to qemuMonitorOpen
doesn't make sense now that we have expanded the QEMU process code to
cover more than the original capabilities usecase.

Removing the monitor lock makes the qemuConnectMonitorQmp code
consistent with the qemuConnectMonitor code used to establish the
monitor when QEMU process is started for domains.

Signed-off-by: Chris Venteicher <cventeic at redhat.com>
---
 src/qemu/qemu_process.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 4dbc7038fd..2f9c1701a3 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -8297,8 +8297,6 @@ qemuConnectMonitorQmp(qemuProcessPtr proc)
 
     VIR_STEAL_PTR(proc->mon, mon);
 
-    virObjectLock(proc->mon);
-
     /* Exit capabilities negotiation mode and enter QEMU command mode
      * by issuing qmp_capabilities command to QEMU */
     if (qemuMonitorSetCapabilities(proc->mon) < 0) {
-- 
2.17.1




More information about the libvir-list mailing list