[libvirt] [PATCH] build: Fix uninstall when WITH_APPARMOR_PROFILES is defined

Jim Fehlig jfehlig at suse.com
Tue Nov 13 19:04:34 UTC 2018


On 11/13/18 10:14 AM, Andrea Bolognani wrote:
> On Wed, 2018-11-07 at 17:44 -0700, Jim Fehlig wrote:
> [...]
>> @@ -96,6 +96,10 @@ install-apparmor-local:
>>   		'usr.lib.libvirt.virt-aa-helper'" \
>>   		>$(APPARMOR_LOCAL_DIR)/usr.lib.libvirt.virt-aa-helper
> 
> Pre-existing lack of quoting... I've fixed it with a trivial patch
> already.

Thanks!

>> +uninstall-apparmor-local:
>> +	rm -f "$(APPARMOR_LOCAL_DIR)/usr.lib.libvirt.virt-aa-helper"
>> +	rmdir $(APPARMOR_LOCAL_DIR) || :
> 
> Missing quotes here as well. Once you fix that,
> 
>    Reviewed-by: Andrea Bolognani <abologna at redhat.com>

I've fixed it and pushed. While doing so I noticed a lot of pre-existing lack of 
quoting throughout the various Makefile.am :-). I'm not sure these are worth 
fixing given the lack problem reports...

Regards,
Jim




More information about the libvir-list mailing list