[libvirt] [PATCH v4 0/2] Adding partial support for LXC 3.0 rebased configs.

[John Ferlan]

On 11/14/18 12:25 PM, Julio Faracco wrote:
> This series adds enhacements for LXC to cover rebased config settings
> for version 3.0 without remove legacy ones. This serie includes some
> test cases to cover new config files too. The title mentions the word
> "partial" because there is a huge change with network settings which
> this commit does not cover.
> 
> History:
>   v1-v2: Michal's suggestions to handle differences between versions.
>   v2-v3: Adding suggestions from Pino and John too.
>   v3-v4: Appluing tests for LXC v3.
> 
> Julio Faracco (2):
>   lxc: Include support to lxc version 3.0 or higher.
>   tests: Adding tests cases to cover rebased settings for LXC 3.0.
> 
>  src/lxc/lxc_native.c                          | 52 ++++++++++++++-----
>  .../lxcconf2xml-blkiotune-v3.config           | 11 ++++
>  .../lxcconf2xml-cpusettune-v3.config          |  6 +++
>  .../lxcconf2xml-cputune-v3.config             |  7 +++
>  .../lxcconf2xml-ethernet-v3.config            | 44 ++++++++++++++++
>  .../lxcconf2xml-fstab-v3.config               | 37 +++++++++++++
>  .../lxcconf2xml-idmap-v3.config               |  5 ++
>  .../lxcconf2xml-macvlannetwork-v3.config      | 13 +++++
>  .../lxcconf2xml-memtune-v3.config             | 10 ++++
>  .../lxcconf2xml-nonenetwork-v3.config         |  4 ++
>  .../lxcconf2xml-nonetwork-v3.config           |  3 ++
>  .../lxcconf2xml-physnetwork-v3.config         | 11 ++++
>  .../lxcconf2xml-simple-v3.config              | 45 ++++++++++++++++
>  .../lxcconf2xml-vlannetwork-v3.config         | 12 +++++
>  tests/lxcconf2xmltest.c                       | 51 +++++++++++++++++-
>  15 files changed, 295 insertions(+), 16 deletions(-)
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-blkiotune-v3.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-cpusettune-v3.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-cputune-v3.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-ethernet-v3.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-fstab-v3.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-idmap-v3.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-macvlannetwork-v3.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-memtune-v3.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-nonenetwork-v3.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-nonetwork-v3.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-physnetwork-v3.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-simple-v3.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-vlannetwork-v3.config
> 

Reviewed-by: John Ferlan <jferlan at redhat.com>
(and pushed)

John

(now let's see if the various CI builders are happy too)