[libvirt] [PATCH] util: Fix virpci compilation on non-Linux

Andrea Bolognani abologna at redhat.com
Thu Nov 15 15:00:48 UTC 2018


We were mistakenly skipping virZPCIDeviceAddressIsEmpty() and
virZPCIDeviceAddressIsValid() when compiling on non-Linux,
which unsurprisingly ended up causing linking failures later
in the build process.

Clue-stick-by: Peter Krempa <pkrempa at redhat.com>
Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
Pushed as build fix.

 src/util/virpci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virpci.c b/src/util/virpci.c
index efa2d1662a..66aae60baa 100644
--- a/src/util/virpci.c
+++ b/src/util/virpci.c
@@ -2561,7 +2561,6 @@ virPCIDeviceAddressParse(char *address,
     return ret;
 }
 
-#ifdef __linux__
 
 bool
 virZPCIDeviceAddressIsValid(virZPCIDeviceAddressPtr zpci)
@@ -2588,6 +2587,7 @@ virZPCIDeviceAddressIsEmpty(const virZPCIDeviceAddress *addr)
     return !(addr->uid || addr->fid);
 }
 
+#ifdef __linux__
 
 /*
  * returns true if equal
-- 
2.19.1




More information about the libvir-list mailing list