[libvirt] [PATCH 1/3] conf: Fix error flow in virDomainPCIAddressEnsureAddr()

Pavel Hrdina phrdina at redhat.com
Fri Nov 16 18:15:58 UTC 2018


On Fri, Nov 16, 2018 at 05:21:29PM +0100, Andrea Bolognani wrote:
> This avoids setting 'ret' multiple times, which will result
> in errors being masked if the first operation fails but the
> second one succeeds.
> 
> Introduced-by: f183b87fc1dbcc6446ac3c1cef9cdd345b9725fb
> Spotted-by: Coverity
> Reported-by: John Ferlan <jferlan at redhat.com>
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  src/conf/domain_addr.c | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20181116/80fb1a43/attachment-0001.sig>


More information about the libvir-list mailing list