[libvirt] [PATCH v2] util: netdevbridge: fall back to ioctl from sysfs

[Daniel P. Berrangé]

On Tue, Nov 20, 2018 at 01:25:46PM +0100, Christian Ehrhardt wrote:
> There are certain cases e.g. containers where the sysfs path might
> exists, but might fail. Unfortunately the exact restrictions are only
> known to libvirt when trying to write to it so we need to try it.
> 
> But in case it fails there is no need to fully abort, in those cases try
> to fall back to the older ioctl interface which can still work.
> 
> That makes setting up a bridge in unprivileged LXD containers work.
> 
> Fixes: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1802906
> 
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt at canonical.com>
> Reported-by: Brian Candler <b.candler at pobox.com>
> ---
>  src/util/virnetdevbridge.c | 48 +++++++++++++++++++++-----------------
>  1 file changed, 26 insertions(+), 22 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|