[libvirt] [PATCH v4 10/37] qemu_capabilities: Stop QEMU process before freeing

Chris Venteicher cventeic at redhat.com
Sat Nov 3 03:13:11 UTC 2018


Follow the convention established in qemu_process of
1) alloc process structure
2) start process
3) use process
4) stop process
5) free process data structure

The process data structure persists after the process activation fails
or the process dies or is killed so stderr strings can be retrieved
until the process data structure is freed.

Signed-off-by: Chris Venteicher <cventeic at redhat.com>
---
 src/qemu/qemu_capabilities.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 1d83ebdbe0..359b6fbb9b 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -4306,6 +4306,7 @@ virQEMUCapsInitQMP(virQEMUCapsPtr qemuCaps,
     ret = 0;
 
  cleanup:
+    qemuProcessStopQmp(proc);
     qemuProcessFree(proc);
     return ret;
 }
-- 
2.17.1




More information about the libvir-list mailing list