[libvirt] [PATCH v2 2/8] qemu: Allow coldunplugging of hub device

[Han Han]

On Tue, Nov 6, 2018 at 6:29 AM John Ferlan <jferlan at redhat.com> wrote:

>
>
> On 10/12/18 4:50 AM, Han Han wrote:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1375423
> >
> > Signed-off-by: Han Han <hhan at redhat.com>
> > ---
> >  src/conf/domain_conf.c   | 30 ++++++++++++++++++++++++++++++
> >  src/conf/domain_conf.h   |  3 +++
> >  src/libvirt_private.syms |  1 +
> >  src/qemu/qemu_driver.c   | 10 +++++++++-
> >  4 files changed, 43 insertions(+), 1 deletion(-)
> >
>
> I assume no concerns over something that could be attached to a port on
> the hub... I guess for a cold unplug it probably won't matter so much.
>
For the usb hub coldunplug, I find a concern. If a usb device attatched
to a usb-hub, then we coldunplug the hub, how will the hub and usb device
look like? All disappear OR all remain?

As I know, for scsi and scsi controllers, it is all remaining :)

>
> Reviewed-by: John Ferlan <jferlan at redhat.com>
>
> John
>


-- 
Best regards,
-----------------------------------
Han Han
Quality Engineer
Redhat.

Email: hhan at redhat.com
Phone: +861065339333
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20181107/5146c102/attachment-0001.htm>