[libvirt] [PATCHv8 2/2] tools: Add help docs explaining 'domstats' cache monitor result

[Wang, Huaqiang]

> -----Original Message-----
> From: John Ferlan [mailto:jferlan at redhat.com]
> Sent: Thursday, November 15, 2018 12:19 AM
> To: Wang, Huaqiang <huaqiang.wang at intel.com>; libvir-list at redhat.com
> Cc: Feng, Shaohe <shaohe.feng at intel.com>; Ding, Jian-feng <jian-
> feng.ding at intel.com>; Zang, Rui <rui.zang at intel.com>
> Subject: Re: [PATCHv8 2/2] tools: Add help docs explaining 'domstats'
> cache monitor result
> 
> 
> 
> On 11/13/18 10:25 PM, Wang Huaqiang wrote:
> > Add help document in explaining the cache monitor related 'domstats'
> > result.
> >
> > This patch is written to address John's review comment regarding
> > patch16-v7 and expected to be merged with previous patch and using
> > that patch's committing message.
> >
> > Signed-off-by: Wang Huaqiang <huaqiang.wang at intel.com>
> > ---
> >  src/libvirt-domain.c | 21 ++++++++++++---------
> >  tools/virsh.pod      | 13 +++++++++++++
> >  2 files changed, 25 insertions(+), 9 deletions(-)
> >
> > diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index
> > 4895f9f..67ff430 100644
> > --- a/src/libvirt-domain.c
> > +++ b/src/libvirt-domain.c
> > @@ -11345,15 +11345,18 @@
> virConnectGetDomainCapabilities(virConnectPtr conn,
> >   *     "cpu.user" - user cpu time spent in nanoseconds as unsigned long
> long.
> >   *     "cpu.system" - system cpu time spent in nanoseconds as unsigned
> long
> >   *                    long.
> > - *     "cpu.cache.monitor.count" - tocal cache monitoring groups
> > - *     "cpu.cache.monitor.M.name" - name of cache monitoring group 'M'
> > - *     "cpu.cache.monitor.M.vcpus" - vcpus for cache monitoring group
> 'M'
> > - *     "cpu.cache.monitor.M.bank.count" - total bank number of cache
> monitoring
> > - *                    group 'M'
> > - *     "cpu.cache.monitor.M.bank.N.id" - OS assigned cache bank id for
> cache
> > - *                    'N' in cache monitoring group 'M'
> > - *     "cpu.cache.monitor.M.bank.N.bytes" - monitor's cache occupancy of
> cache
> > - *                    bank 'N' in cache monitoring group 'M'
> > + *     "cpu.cache.monitor.count" - number of cache monitors on this
> domain
> 
> for this domain

got. 

> 
> > + *     "cpu.cache.monitor.<num>.name" - name of cache monitor <num>
> > + *     "cpu.cache.monitor.<num>.vcpus" - vcpu list of cache monitor
> <num>
> > + *     "cpu.cache.monitor.<num>.bank.count" - number of cache banks in
> cache
> > + *                                            monitor <num>
> > + *     "cpu.cache.monitor.<num>.bank.<index>.id" - host allocatd cache id
> for
> 
> allocated
> 

My fault. Thanks.

> > + *                                                 bank <index> in cache
> > + *                                                 monitor <num>
> > + *     "cpu.cache.monitor.<num>.bank.<index>.bytes" - the amount of
> last level
> > + *                                                    cache that domain is
> > + *                                                    using on cache bank <index>
> > + *                                                    (in Byte)
> 
> the number of bytes of last level cache that the domain is using on cache
> bank <index>
>

Thanks.
 
> (and likewise below although there was an extra type there)
> 
> >   *
> >   * VIR_DOMAIN_STATS_BALLOON:
> >   *     Return memory balloon device information.
> > diff --git a/tools/virsh.pod b/tools/virsh.pod index 86c041d..49d9ab6
> > 100644
> > --- a/tools/virsh.pod
> > +++ b/tools/virsh.pod
> > @@ -1011,6 +1011,19 @@ I<--cpu-total> returns:
> >   "cpu.time" - total cpu time spent for this domain in nanoseconds
> >   "cpu.user" - user cpu time spent in nanoseconds
> >   "cpu.system" - system cpu time spent in nanoseconds
> > + "cpu.cache.monitor.count" - number of cache monitors on this domain
> > + "cpu.cache.monitor.<num>.name" - name of cache monitor <num>
> > + "cpu.cache.monitor.<num>.vcpus" - vcpu list of cache monitor <num>
> > + "cpu.cache.monitor.<num>.bank.count" - number of cache banks in
> > +                                        cache monitor <num>
> > + "cpu.cache.monitor.<num>.bank.<index>.id" - host allocatd cache id
> > +                                             for bank <index> in
> > +                                             caach monitor <num>
> 
> cache

My fault. Thanks.

> 
> 
> John
> 

Thanks for review.
Huaqiang

> 
> > + "cpu.cache.monitor.<num>.bank.<index>.bytes" - the amount of last
> > +                                                level cache that
> > +                                                domain is using on
> > +                                                cache bank <index>
> > +                                                (in Byte)
> >
> >  I<--balloon> returns:
> >
> >