[libvirt] [PATCH 3/3] conf: Perform error checking in virDomainDeviceInfoFormat()

Pavel Hrdina phrdina at redhat.com
Fri Nov 16 18:38:03 UTC 2018


On Fri, Nov 16, 2018 at 05:21:31PM +0100, Andrea Bolognani wrote:
> virXMLFormatElement() might fail, but we were not checking
> its return value.
> 
> Fixing this requires us to change virDomainDeviceInfoFormat()
> so that it can report an error back to the caller.
> 
> Introduced-by: 0d6b87335c00451b0923ecc91d617f71e4135bf8
> Spotted-by: Coverity
> Reported-by: John Ferlan <jferlan at redhat.com>
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  src/conf/domain_conf.c | 97 ++++++++++++++++++++++++++++--------------
>  1 file changed, 66 insertions(+), 31 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20181116/2da54127/attachment-0001.sig>


More information about the libvir-list mailing list