[libvirt] [libvirt-perl PATCH] Add support for virDomainSetIOThreadParams
Daniel P. Berrangé
berrange at redhat.com
Tue Nov 20 14:45:05 UTC 2018
On Tue, Nov 20, 2018 at 09:26:28AM -0500, John Ferlan wrote:
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
> Although I suppose a build breaker, it would be good to have someone
> review my (lack of) Perl writing skills. The changes do allow the build
> to pass though ;-).
>
> Changes | 2 ++
> lib/Sys/Virt.xs | 41 +++++++++++++++++++++++++++++++++++++++++
> lib/Sys/Virt/Domain.pm | 39 +++++++++++++++++++++++++++++++++++++++
> 3 files changed, 82 insertions(+)
> @@ -9129,6 +9166,10 @@ BOOT:
> REGISTER_CONSTANT_STR(VIR_PERF_PARAM_ALIGNMENT_FAULTS, PERF_PARAM_ALIGNMENT_FAULTS);
> REGISTER_CONSTANT_STR(VIR_PERF_PARAM_EMULATION_FAULTS, PERF_PARAM_EMULATION_FAULTS);
>
> + REGISTER_CONSTANT_STR(VIR_DOMAIN_IOTHREAD_POLL_MAX_NS, IOTHREAD_PARAM_POLL_MAX_NS);
> + REGISTER_CONSTANT_STR(VIR_DOMAIN_IOTHREAD_POLL_GROW, IOTHREAD_PARAM_POLL_GROW);
> + REGISTER_CONSTANT_STR(VIR_DOMAIN_IOTHREAD_POLL_SHRINK, IOTHREAD_PARAM_POLL_SHRINK);
> +
> REGISTER_CONSTANT_STR(VIR_DOMAIN_BANDWIDTH_IN_AVERAGE, BANDWIDTH_IN_AVERAGE);
> REGISTER_CONSTANT_STR(VIR_DOMAIN_BANDWIDTH_IN_PEAK, BANDWIDTH_IN_PEAK);
> REGISTER_CONSTANT_STR(VIR_DOMAIN_BANDWIDTH_IN_BURST, BANDWIDTH_IN_BURST);
> diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm
> index c56fe4e..a466efc 100644
> --- a/lib/Sys/Virt/Domain.pm
> +++ b/lib/Sys/Virt/Domain.pm
> @@ -1423,6 +1423,13 @@ Delete an existing IOThread by the C<$iothread> value from the guest domain.
> The C<$flags> parameter accepts one or more the CONFIG OPTION constants
> documented later, and defaults to 0 if omitted.
>
> +=item $dom->set_iothread($iothread, $params, $nparams, $flags=0)
> +
> +Set parameters for the IOThread by the C<$iothread> value on the guest domain.
> +The C<$params> parameter
The C<$params> parameter is a hash reference whose keys
are the C<IOTHREAD STATS> constants documented later.
> +The C<$flags> parameter accepts one or more the CONFIG OPTION constants
> +documented later, and defaults to 0 if omitted.
> +
> =item my @stats = $dom->get_cpu_stats($startCpu, $numCpus, $flags=0)
>
> Requests the guests host physical CPU usage statistics, starting
> @@ -2989,6 +2996,34 @@ field in the *Stats APIs.
With the docs fix:
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
More information about the libvir-list
mailing list