[libvirt] [PATCH 1/8] Revert "qemu: hotplug: Prepare disk source in qemuDomainAttachDeviceDiskLive"

John Ferlan jferlan at redhat.com
Tue Oct 2 12:09:23 UTC 2018



On 9/27/18 11:09 AM, Peter Krempa wrote:
> Preparing the storage source prior to assigning the alias will not work
> as the names of the certain objects depend on the alias for the legacy
> hotplug case as we generate the object names for the secrets based on
> the alias.
> 
> This reverts commit 192fdaa614e3800255048a8a70c1292ccf18397a.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  src/qemu/qemu_hotplug.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan at redhat.com>

John

Should the two reverts go into 4.7 and 4.8 maint streams too?




More information about the libvir-list mailing list