[libvirt] [PATCH 52/53] virt-host-validate: rewrite cgroup detection to use util/vircgroup

Michal Privoznik mprivozn at redhat.com
Fri Oct 5 10:14:43 UTC 2018


On 10/02/2018 10:44 AM, Pavel Hrdina wrote:
> This removes code duplication and simplifies cgroup detection.
> As a drawback we will not have separate messages to enable cgroup
> controller in kernel or to mount it.  On the other side the rewrite
> adds support for cgroup v2.
> 
> The kernel config support was wrong because it was parsing
> '/proc/self/cgroup' instead of '/proc/cgroups/' file.
> 
> The mount suggestion is removed as well because it will not work
> with cgroup v2.
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  tools/virt-host-validate-common.c | 162 ++++++------------------------
>  tools/virt-host-validate-common.h |   7 +-
>  tools/virt-host-validate-lxc.c    |  40 ++------
>  tools/virt-host-validate-qemu.c   |  40 ++------
>  4 files changed, 54 insertions(+), 195 deletions(-)

ACK

Michal




More information about the libvir-list mailing list