[libvirt] [PATCH 08/11] qemu: Simplify QEMU binary search

[Peter Krempa]

On Fri, Oct 05, 2018 at 17:18:44 +0200, Andrea Bolognani wrote:
> On Fri, 2018-10-05 at 16:43 +0200, Ján Tomko wrote:
> > On Thu, Sep 20, 2018 at 05:25:26PM +0200, Andrea Bolognani wrote:
> > > @@ -756,6 +755,13 @@ virQEMUCapsInitGuest(virCapsPtr caps,
> > >      */
> > >     binary = virQEMUCapsFindBinaryForArch(hostarch, guestarch);
> > > 
> > > +    /* RHEL doesn't follow the usual naming for QEMU binaries and ships
> > > +     * a single binary named qemu-kvm outside of $PATH instead */
> > 
> > This does not look like something upstream libvirt should worry about.
> 
> I would be simple enough to turn this into a downstream-only patch;
> however, by doing so we would lose the ability to run unchanged
> upstream libvirt on top of RHEL, so I think it's preferable to
> leave it alone.

Well, if we are going to bend the rules and make a hack for the mess
some downstream distro made, then we should keep the original code which
allows to add mess for other distros as well.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20181008/ee220e83/attachment-0001.sig>