[libvirt] [PATCH v2 4/4] virfile: Rework virFileIsSharedFixFUSE

[Jiri Denemark]

On Wed, Oct 10, 2018 at 16:43:03 +0200, Michal Privoznik wrote:
> There are couple of things wrong with the current implementation.
> The first one is that in the first loop the code tries to build a
> list of fuse.glusterfs mount points. Well, since the strings are
> allocated in a temporary buffer and are not duplicated this
> results in wrong decision made later in the code.
> 
> The second problem is that the code does not take into account
> subtree mounts. For instance, if there's a fuse.gluster mounted
> at /some/path and another FS mounted at /some/path/subdir the
> code would not recognize this subdir mount.
> 
> Reported-by: Han Han <hhan at redhat.com>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> 
> diff to v1:
> 
> - fixed while() loop - added more checks for @p
> - fixed @maxMatching assignment (facepalm)
> 
>  src/util/virfile.c            | 59 ++++++++++++++---------------------
>  tests/virfiledata/mounts3.txt |  2 ++
>  tests/virfiletest.c           |  2 ++
>  3 files changed, 28 insertions(+), 35 deletions(-)

Reviewed-by: Jiri Denemark <jdenemar at redhat.com>