[libvirt] [PATCH v3] virfile: fix cast-align error

Bjoern Walk bwalk at linux.ibm.com
Thu Oct 11 01:52:41 UTC 2018


Michal Privoznik <mprivozn at redhat.com> [2018-10-10, 05:35PM +0200]:
> On 10/10/2018 10:04 AM, Bjoern Walk wrote:
> > From: Marc Hartmayer <mhartmay at linux.ibm.com>
> > 
> > On s390x the struct member f_type of statsfs is hard coded to 'unsigned
> > int'. Change virFileIsSharedFixFUSE() to take a 'long long int' and use
> > a temporary to avoid pointer-casting.
> > 
> > This fixes the following error:
> > ../../src/util/virfile.c:3578:38: error: cast increases required alignment of target type [-Werror=cast-align]
> >          virFileIsSharedFixFUSE(path, (long *) &sb.f_type);
> > 
> > Signed-off-by: Marc Hartmayer <mhartmay at linux.ibm.com>
> > Signed-off-by: Bjoern Walk <bwalk at linux.ibm.com>
> > ---
> >  src/util/virfile.c | 23 +++++++++++++----------
> >  1 file changed, 13 insertions(+), 10 deletions(-)
> 
> ACKed and pushed.

Thanks a lot!

-- 
IBM Systems
Linux on Z & Virtualization Development
--------------------------------------------------
IBM Deutschland Research & Development GmbH
Schönaicher Str. 220, 71032 Böblingen
Phone: +49 7031 16 1819
--------------------------------------------------
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 902 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20181011/9f9b5430/attachment-0001.sig>


More information about the libvir-list mailing list