[libvirt] [PATCH v6 10/13] qemu: Generate and use zPCI device in QEMU command line

[Yi Min Zhao]

在 2018/10/12 下午10:44, Andrea Bolognani 写道:
> On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote:
> [...]
>> @@ -3089,6 +3146,10 @@ qemuBuildControllerDevCommandLine(virCommandPtr cmd,
>>                   goto cleanup;
>>   
>>               if (devstr) {
>> +                if (qemuCommandAddExtDevice(cmd, &cont->info) < 0) {
>> +                    VIR_FREE(devstr);
>> +                    goto cleanup;
>> +                }
> Please add an empty line here...
>
> [...]
>> @@ -4531,6 +4604,9 @@ qemuBuildVideoCommandLine(virCommandPtr cmd,
>>           if (video->primary) {
>>               if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIDEO_PRIMARY)) {
>>   
>> +                if (qemuCommandAddExtDevice(cmd,
>> +                                            &def->videos[i]->info) < 0)
>> +                    return -1;
> ... and one here.
>
>
> Reviewed-by: Andrea Bolognani <abologna at redhat.com>
>
OK. Thanks!

-- 
Yi Min