[libvirt] [PATCH v6 11/13] qemu: Add hotpluging support for PCI devices on S390 guests

[Yi Min Zhao]

在 2018/10/12 下午10:57, Andrea Bolognani 写道:
> On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote:
> [...]
>> @@ -1381,7 +1469,8 @@ qemuDomainAttachNetDevice(virQEMUDriverPtr driver,
>>               goto cleanup;
>>       }
>>   
>> -    if (qemuDomainIsS390CCW(vm->def) &&
>> +    if (net->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI &&
>> +        qemuDomainIsS390CCW(vm->def) &&
>>           virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_CCW)) {
> You can put the new condition in the second line instead of the
> first one to reduce the size of the diff without affecting the
> result.
>
>
> With the usual caveat that someone familiar with hotplug should
> really give this at least a look before it gets merged, it looks
> sane enough to me so it gets my
>
>    Reviewed-by: Andrea Bolognani <abologna at redhat.com>
>
Got it. Thanks!

-- 
Yi Min