[libvirt] [PATCH RFC 0/4]] nwfilter: don't reinstantiate filters if they are not changed

Nikolay Shirokovskiy nshirokovskiy at virtuozzo.com
Thu Oct 18 06:49:30 UTC 2018


The series adds optimization in network filters instantiation as suggested
in [1]. Applied on top of [2].

However this approach has drawback I'm unfortunately discovered too late)
Next steps will left us with no network filters after this series applied:

systemctl stop libvirtd
systemctl restart firewalld
systemctl start libvirtd

In case of system update libvirt binaries ctime will change and filters will be
reinstalled.

[1] https://www.redhat.com/archives/libvir-list/2018-October/msg00657.html
[2] https://www.redhat.com/archives/libvir-list/2018-October/msg00787.html

Nikolay Shirokovskiy (4):
  nwfilter: add nwfilter hash
  nwfilter: don't reinstantiate filters if they are not changed
  nwfilter: force filters reinstantiation on firewalld reload
  nwfilter: force filters reinstantiation on binary update

 src/conf/virnwfilterbindingobj.c       |  40 +++++++++
 src/conf/virnwfilterbindingobj.h       |  10 +++
 src/conf/virnwfilterobj.c              | 145 +++++++++++++++++++++++++++++++++
 src/conf/virnwfilterobj.h              |   9 ++
 src/libvirt_private.syms               |   6 ++
 src/nwfilter/nwfilter_driver.c         |  11 ++-
 src/nwfilter/nwfilter_gentech_driver.c |  67 +++++++++++++--
 src/nwfilter/nwfilter_gentech_driver.h |   6 +-
 8 files changed, 283 insertions(+), 11 deletions(-)

-- 
1.8.3.1




More information about the libvir-list mailing list