[libvirt] [PULL 20/45] memory-device: improve "range conflicts" error message
Eduardo Habkost
ehabkost at redhat.com
Thu Oct 18 20:03:57 UTC 2018
From: David Hildenbrand <david at redhat.com>
Handle id==NULL better and indicate that we are dealing with memory
devices.
Signed-off-by: David Hildenbrand <david at redhat.com>
Message-Id: <20181005092024.14344-4-david at redhat.com>
Reviewed-by: David Gibson <david at gibson.dropbear.id.au>
Reviewed-by: Philippe Mathieu-Daudé <philmd at redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost at redhat.com>
---
hw/mem/memory-device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
index 7c706fadfc..0624184c40 100644
--- a/hw/mem/memory-device.c
+++ b/hw/mem/memory-device.c
@@ -175,7 +175,8 @@ uint64_t memory_device_get_free_addr(MachineState *ms, const uint64_t *hint,
if (ranges_overlap(md_addr, md_size, new_addr, size)) {
if (hint) {
const DeviceState *d = DEVICE(md);
- error_setg(errp, "address range conflicts with '%s'", d->id);
+ error_setg(errp, "address range conflicts with memory device"
+ " id='%s'", d->id ? d->id : "(unnamed)");
goto out;
}
new_addr = QEMU_ALIGN_UP(md_addr + md_size, align);
--
2.18.0.rc1.1.g3f1ff2140
More information about the libvir-list
mailing list