[libvirt] [snmp PATCH 09/20] src: Fix header file defines

Pino Toscano ptoscano at redhat.com
Mon Oct 29 17:10:09 UTC 2018


On Thursday, 18 October 2018 14:26:47 CET Michal Privoznik wrote:
> To avoid multiple includes, header files start with:
> 
>   #ifndef __SOMETHING__
>   # define __SOMETHING__
> 
> Well, SOMETHING should be the file name, and there should be a
> space after hash and before 'define'.

Note that identifier start that with two underscores (or even with two
underscores in their name, IIRC) are reserved for the system.
I know the likelyhood of a name conflict with a system identifier with
LIBVIRT in the name is very low, still I saw people reporting these
"reserved names used" issues in the past.

I'd simply use LIBVIRTSNMP_ (or something like that) as prefix.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20181029/4aec9467/attachment-0001.sig>


More information about the libvir-list mailing list