[libvirt] [PATCH] qemu: Report warning if QoS is set for vhostuser interface

Michal Privoznik mprivozn at redhat.com
Wed Oct 31 15:47:45 UTC 2018


https://bugzilla.redhat.com/show_bug.cgi?id=1524230

Because of historical reasons, we are not denying starting a
domain which has QoS set for unsupported type of device. We do
report just a warning instead. And even though we perhaps used to
do so for vhostuser it got lost somewhere. Bring it back.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/qemu/qemu_command.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 6e3ff67660..489e8bc689 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -8246,6 +8246,12 @@ qemuBuildVhostuserCommandLine(virQEMUDriverPtr driver,
         goto cleanup;
     }
 
+    if (virDomainNetGetActualBandwidth(net)) {
+        VIR_WARN("setting bandwidth on interfaces of "
+                 "type '%s' is not implemented yet",
+                 virDomainNetTypeToString(VIR_DOMAIN_NET_TYPE_VHOSTUSER));
+    }
+
     switch ((virDomainChrType)net->data.vhostuser->type) {
     case VIR_DOMAIN_CHR_TYPE_UNIX:
         if (!(chardev = qemuBuildChrChardevStr(logManager, secManager,
-- 
2.18.1




More information about the libvir-list mailing list