[libvirt] [PATCH 2/6] conf: Move virDomainDeviceAddressIsValid() to device_conf

Ján Tomko jtomko at redhat.com
Mon Sep 3 15:18:34 UTC 2018


On Fri, Aug 31, 2018 at 04:00:43PM +0200, Andrea Bolognani wrote:
>The function is called on a virDomainDeviceInfo, so it
>should be declared along with it.
>
>Moving this function requires moving and making public
>virDomainDeviceCCWAddressIsValid() as well, but that's
>perfectly fine since the same reasoning above also
>applies to it, due to virDomainDeviceCCWAddress being
>(correctly) declared in device_conf.
>
>Signed-off-by: Andrea Bolognani <abologna at redhat.com>
>---
> src/conf/device_conf.c   | 36 ++++++++++++++++++++++++++++++++++++
> src/conf/device_conf.h   |  5 +++++
> src/conf/domain_conf.c   | 36 ------------------------------------
> src/conf/domain_conf.h   |  2 --
> src/libvirt_private.syms |  3 ++-
> 5 files changed, 43 insertions(+), 39 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180903/bb3ef46e/attachment-0001.sig>


More information about the libvir-list mailing list