[libvirt] [PATCH] tests: skip qemublocktest if building without YAJL

[Ján Tomko]

On Tue, Sep 04, 2018 at 02:00:21PM +0200, Andrea Bolognani wrote:
>On Tue, 2018-09-04 at 12:01 +0100, Daniel P. Berrangé wrote:
>> If no JSON parser is available qemublocktest fails, so skip its execution.
>>
>> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
>> ---
>>
>> Pushed as a build fix for platforms without JSON parser installed
>
>Which platforms? All machines in our CI environments should have
>yajl installed.
>
>Either way, IIRC during the switch to Jansson we also made the
>JSON parser mandatory when building the QEMU driver, a change
>which I believe we might have reverted when switching back to
>yajl: can we just have that back? Or are there some issues
>preventing us from doing so?

Yes, as a part of the Jansson revert I also reverted the build defaults:
commit 5a58b5ed6803e71e32e5d6f8c6e3b68874d085fb
    Revert "build: switch --with-qemu default from yes to check"
commit f204cf51035f51b979dec18ee526e418139fa874
    Revert "build: require Jansson if QEMU driver is enabled"

Because I unwisely dropped the WITH_YAJL->WITH_JSON rename that was
present in earlier series and they used 'WITH_JANSSON'.


At runtime, we require JSON for all the supported QEMUs, so the only
thing stopping us from re-adding the check is that we need to change
the QEMU driver default from 'yes' to 'check':
https://www.redhat.com/archives/libvir-list/2018-May/msg01060.html

(which, in combination with a change of the required library left some
developers confused when the QEMU driver quietly stopped building)

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180904/d8f3b42c/attachment-0001.sig>