[libvirt] [libvirt-snmp][PATCH 3/3] configure: Prevent autoreconf from installing `compile' file

[Ján Tomko]

s/Prevent autoreconf from installing `compile' file/Modernize/

On Wed, Sep 05, 2018 at 10:55:40AM +0200, Michal Privoznik wrote:
>When running autoreconf, it installs this `compile' file which

s/installs/creates/ maybe?

I'd expect 'install' to refer to the process of copying the resulting
files into the system by 'make install'

>triggers my OCD. It appears that our configure script can be
>modernized a bit which makes it stop.

It merely puts them into the requested AUX_DIR

>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> configure.ac | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/configure.ac b/configure.ac
>index f520927..c8df41d 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -1,8 +1,12 @@
> AC_INIT([libvirt-snmp],[0.0.3],[libvir-list at redhat.com],[],[http://libvirt.org])
>-AM_INIT_AUTOMAKE([-Wall -Werror])
>+AC_CONFIG_SRCDIR(src/libvirtSnmp.c)
>+AC_CONFIG_AUX_DIR([build-aux])
> AC_CONFIG_HEADERS([config.h])
>+AM_INIT_AUTOMAKE([-Wall -Werror])

Not moving this line would make the diff smaller.

>
>-AC_PREREQ([2.50])

>+AC_CANONICAL_HOST

Not necessary, 'host' is not used anywhere.

>+
>+AM_SILENT_RULES([yes])
>

Without the AM_INIT_AUTOMAKE and AC_CANONICAL_HOST changes:

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180905/c6fdc983/attachment-0001.sig>