[libvirt] [PATCH v5 1/4] qemu: implementing qemuAgentGetHostname() function.

[John Ferlan]

On 09/05/2018 12:20 AM, Julio Faracco wrote:
> This commit implements the function qemuAgentGetHostname() that uses
> the QEMU guest agent command 'guest-get-host-name' to retrieve the
> guest hostname of virtual machine running the QEMU-GA.
> 
> Signed-off-by: Julio Faracco <jcfaracco at gmail.com>
> ---
>  src/qemu/qemu_agent.c | 47 +++++++++++++++++++++++++++++++++++++++++++
>  src/qemu/qemu_agent.h |  4 ++++
>  2 files changed, 51 insertions(+)
> 
> diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
> index bf08871f18..ac728becef 100644
> --- a/src/qemu/qemu_agent.c
> +++ b/src/qemu/qemu_agent.c
> @@ -1683,6 +1683,53 @@ qemuAgentUpdateCPUInfo(unsigned int nvcpus,
>  }
>  
>  
> +int
> +qemuAgentGetHostname(qemuAgentPtr mon,
> +                     char **hostname)
> +{
> +    int ret = -1;
> +    virJSONValuePtr cmd;
> +    virJSONValuePtr reply = NULL;
> +    virJSONValuePtr data = NULL;
> +    const char *result = NULL;
> +
> +    cmd = qemuAgentMakeCommand("guest-get-host-name",
> +                               NULL);
> +
> +    if (!cmd)
> +        return ret;
> +
> +    if (qemuAgentCommand(mon, cmd, &reply, true,
> +                         VIR_DOMAIN_QEMU_AGENT_COMMAND_BLOCK) < 0)
> +        goto cleanup;
> +
> +    if (qemuAgentCheckError(cmd, reply) < 0)
> +        goto cleanup;

Hmmm - I hope my comments weren't misconstrued.  I think your v3 to drop
the call is correct since qemuAgentCommand already does this.

My point there was that there were a couple of other calls that added a
call to qemuAgentCheckError after qemuAgentCommand, but that doesn't
seem "right" based on mkletzan's commit 5b3492fadb.

In any case, I'll remove it in my branch and wait for your 'OK' before
pushing the series.

Reviewed-by: John Ferlan <jferlan at redhat.com>

John