[libvirt] [PATCH v2 2/7] qemu: Check type range for virtio-input devices

Ján Tomko jtomko at redhat.com
Thu Sep 6 12:37:32 UTC 2018


On Thu, Sep 06, 2018 at 02:22:14PM +0200, Andrea Bolognani wrote:
>Signed-off-by: Andrea Bolognani <abologna at redhat.com>
>---
> src/qemu/qemu_command.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
>index 877269f52e..72d8bb4cf6 100644
>--- a/src/qemu/qemu_command.c
>+++ b/src/qemu/qemu_command.c
>@@ -4096,7 +4096,10 @@ qemuBuildVirtioInputDevStr(const virDomainDef *def,
>         virQEMUBuildBufferEscapeComma(&buf, dev->source.evdev);
>         break;
>     case VIR_DOMAIN_INPUT_TYPE_LAST:
>-        break;
>+    default:
>+        virReportEnumRangeError(virDomainInputType,
>+                                dev->type);

This would comfortably fit on one line.

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180906/9a71ac0f/attachment-0001.sig>


More information about the libvir-list mailing list