[libvirt] [PATCH 1/2] qemu: Remove duplicated qemuAgentCheckError

John Ferlan jferlan at redhat.com
Fri Sep 7 20:01:26 UTC 2018


Commit 5b3492fadb moved qemuAgentCheckError calls into
qemuAgentCommand for various reasons; however, subsequent
commit b1aa91e14 restored the call. So let's just remove
the duplicitous call from qemuAgentSetVCPUsCommand.

Signed-off-by: John Ferlan <jferlan at redhat.com>
---
 src/qemu/qemu_agent.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index 0a1f3195dd..102ac36f0f 100644
--- a/src/qemu/qemu_agent.c
+++ b/src/qemu/qemu_agent.c
@@ -1544,9 +1544,6 @@ qemuAgentSetVCPUsCommand(qemuAgentPtr mon,
                          VIR_DOMAIN_QEMU_AGENT_COMMAND_BLOCK) < 0)
         goto cleanup;
 
-    if (qemuAgentCheckError(cmd, reply) < 0)
-        goto cleanup;
-
     /* All negative values are invalid. Return of 0 is bogus since we wouldn't
      * call the guest agent so that 0 cpus would be set successfully. Reporting
      * more successfully set vcpus that we've asked for is invalid. */
-- 
2.17.1




More information about the libvir-list mailing list