[libvirt] [PATCH 7/9] tests: do not mangle real qemu caps in xml2argvtest

Michal Privoznik mprivozn at redhat.com
Tue Sep 11 11:45:29 UTC 2018


On 09/09/2018 04:10 AM, Ján Tomko wrote:
> None of the things testUpdateQEMUCaps adjusts are applicable
> for tests that use the DO_TEST_CAPS macros, i.e.
> real QEMU capabilities parsed from the XML files:
> 
> The architecture must be chosen before we even open the caps
> file, CPU models are already present and the expensive HostModel
> computation was already done in virQEMUCapsLoadCache.
> 
> Introduce FLAG_REAL_CAPS and skip the whole testUpdateQEMUCaps
> function for DO_TEST_CAPS.
> 
> This speeds up the test by 25 %
> 
> Signed-off-by: Ján Tomko <jtomko at redhat.com>
> ---
>  tests/qemuxml2argvtest.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 

ACK

Michal




More information about the libvir-list mailing list