[libvirt] [PATCH 2/9] tests: add macro for dealing with exclusive flags

Michal Privoznik mprivozn at redhat.com
Tue Sep 11 11:45:48 UTC 2018


On 09/09/2018 04:10 AM, Ján Tomko wrote:
> We can reject some non-sensical combinations with an error
> message, once we add flags for them.
> 
> Introduce a macro to make this easier.
> 
> Signed-off-by: Ján Tomko <jtomko at redhat.com>
> ---
>  tests/qemuxml2argvtest.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
> index 04b6c00eba..b04cf7c923 100644
> --- a/tests/qemuxml2argvtest.c
> +++ b/tests/qemuxml2argvtest.c
> @@ -467,6 +467,21 @@ testCompareXMLToStartupXML(const void *data)
>  }
>  
>  
> +# define TEST_EXCLUSIVE_FLAGS(FLAG1, FLAG2) \
> +    if ((testFlags & FLAG1) && (testFlags & FLAG2)) { \
> +        VIR_TEST_DEBUG("Flags %s and %s are mutually exclusive\n", \
> +                       #FLAG1, #FLAG2); \
> +        return -1; \
> +    }
> +
> +

What's wrong with VIR_EXCLUSIVE_FLAGS_RET()?

Michal




More information about the libvir-list mailing list