[libvirt] [PATCH v5 06/13] conf: Introduce address caching for PCI extensions

Andrea Bolognani abologna at redhat.com
Thu Sep 13 08:23:12 UTC 2018


On Thu, 2018-09-13 at 15:58 +0800, Yi Min Zhao wrote:
> 在 2018/9/12 下午6:37, Andrea Bolognani 写道:
> > Too bad fid can go all the way to UINT32_MAX, otherwise we could
> > have just stored them in the pointer after offsetting them by one
> > and thus worked around the issue...
> > 
> > I guess forbidding users from using UINT32_MAX as a fid is not an
> > option, right?
> 
> We have discussed this. FID 0~UINT32_MAX are allowed in s390.
> We shouldn't forbid users. So we have to keep the hashtable code
> as it is.

That's a bit unfortunate, but okay. Just ignore the comments about
it and keep the current implementation then.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list