[libvirt] [tck PATCH] eliminate use of deprecated brctl in network tests

John Ferlan jferlan at redhat.com
Mon Sep 17 22:51:08 UTC 2018



On 09/13/2018 03:11 PM, Laine Stump wrote:
> brctl is part of the bridge-utils package, which has been deprecated /
> replaced by the "ip" and "bridge" commands in the iproute package in
> all modern distros. This patch removes the few usages of brctl in
> libvirt-tck's network tests, replacing it with a functional equivalent
> that uses "ip link show type bridge" instead.
> 
> Signed-off-by: Laine Stump <laine at laine.org>
> ---
>  scripts/networks/networkxml2hostout/tck-testnet-1.dat      | 4 ++--
>  scripts/networks/networkxml2hostout/tck-testnet-1.post.dat | 2 +-
>  scripts/networks/networkxml2hostout/tck-testnet-2.dat      | 4 ++--
>  scripts/networks/networkxml2hostout/tck-testnet-2.post.dat | 2 +-
>  scripts/networks/networkxml2hostout/tck-testnet-3.dat      | 4 ++--
>  scripts/networks/networkxml2hostout/tck-testnet-3.post.dat | 2 +-
>  6 files changed, 9 insertions(+), 9 deletions(-)
> 

As Colonel Klink would say ... ;-)

But still looks fine to me...  Output at least matches what I see too.

Reviewed-by: John Ferlan <jferlan at redhat.com>

John




More information about the libvir-list mailing list