[libvirt] [PATCH] qemu: Fix error reporting in qemuDomainSaveImageStartVM

[John Ferlan]

On 09/18/2018 03:59 AM, Jiri Denemark wrote:
> When restoring a domain from a compressed image, we launch an
> intermediate process for decompressing the saved data. If QEMU fails to
> load the data for some reason, we force close the stdin/stdout file
> descriptors of the intermediate process and wait for it to die. However,
> virCommandWait can report various errors which would overwrite the real
> error from QEMU. Thus instead of getting something useful:
> 
>     internal error: process exited while connecting to monitor:
>     2018-09-17T15:17:29.998910Z qemu-system-x86_64: can't apply global
>     Skylake-Client-x86_64-cpu.osxsave=off: Property '.osxsave' not found
> 
> we could get an irrelevant error message:
> 
>     internal error: Child process (lzop -dc --ignore-warn) unexpected
>     fatal signal 13
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  src/qemu/qemu_driver.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 

Reviewed-by: John Ferlan <jferlan at redhat.com>

John

Side note, reviewing Michal's recent patches, he used
virErrorPreserveLast and virErrorRestore... IDC which is used, but it
does leave the question why pkrempa didn't modify existing callers to
use one mechanism or another... Two very similar paths with some slight
but perhaps important differences.  Different problem for a different day.