[libvirt] [PATCH v3] qemu: Ignore nwfilter binding instantiation issues during reconnect

[Michal Privoznik]

On 08/24/2018 04:02 PM, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1607202
> 
> It's essentially stated in the nwfilterBindingDelete that we
> will allow the admin to shoot themselves in the foot by deleting
> the nwfilter binding which then allows them to undefine the
> nwfilter that is in use for the running guest...
> 
> However, by allowing this we cause a problem for libvirtd
> restart reconnect processing which would then try to recreate
> the missing binding attempting to use the deleted filter
> resulting in an error and thus shutting the guest down.
> 
> So rather than keep adding virDomainConfNWFilterInstantiate
> flags to "ignore" specific error conditions, modify the logic
> to ignore, but VIR_WARN errors other than ignoreExists. This
> will at least allow the guest to not shutdown for only nwfilter
> binding errors that we can now perhaps recover from since we
> have the binding create/delete capability.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
> 
>  v2: https://www.redhat.com/archives/libvir-list/2018-August/msg01567.html
> 
>  Differences to v2.  Leave the ignoreExists bool, but just allow and
>  VIR_WARN other errors from virDomainConfNWFilterInstantiate. Continue
>  processing all filters from error point too.
> 
>  src/qemu/qemu_process.c | 24 ++++++++++++++++--------
>  1 file changed, 16 insertions(+), 8 deletions(-)

ACK

Michal