[libvirt] [PATCH] Remove ignore_value or void from unlink calls

Erik Skultety eskultet at redhat.com
Thu Sep 20 14:17:17 UTC 2018


On Thu, Sep 20, 2018 at 08:12:06AM -0400, John Ferlan wrote:
> There seems to be no need to add the ignore_value wrapper or
> caste with (void) to the unlink() calls, so let's just remove
> them. I assume at one point in time Coverity complained. So,
> let's just be consistent - those that care to check the return
> status can and those that don't can just have the naked unlink.
>
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>
>  As a result of Michal's review comment on my recent storage driver
>  error path series...

MinGW is happy, Clang is happy, what more can one wish for?! :)

Reviewed-by: Erik Skultety <eskultet at redhat.com>




More information about the libvir-list mailing list