[libvirt] [Qemu-devel] [PATCH v2 2/4] net: Deprecate the "name" parameter of -net

[Markus Armbruster]

Thomas Huth <thuth at redhat.com> writes:

>  In early times, network backends were specified by a "vlan" and "name"
> tuple. With the introduction of netdevs, the "name" was replaced by an
> "id" (which is supposed to be unique), but the "name" parameter stayed
> as an alias which could be used instead of "id". Unfortunately, we miss
> the duplication check for "name":
>
>  $ qemu-system-x86_64 -net user,name=n1 -net user,name=n1
>
> ... starts without an error, while "id" correctly complains:
>
>  $ qemu-system-x86_64 -net user,id=n1 -net user,id=n1
>  qemu-system-x86_64: -net user,id=n1: Duplicate ID 'n1' for net
>
> Instead of trying to fix the code for the legacy "name" parameter, let's

Has been that way for a long time without anyone complaining, so leaving
it that way for a little longer is okay.

> rather get rid of this old interface and deprecate the "name" parameter
> now - this will also be less confusing for the users in the long run.
>
> Signed-off-by: Thomas Huth <thuth at redhat.com>

Reviewed-by: Markus Armbruster <armbru at redhat.com>