[libvirt] [PATCH 32/47] vircgroup: extract virCgroupV1(Set|Get)Memory*Limit

Ján Tomko jtomko at redhat.com
Tue Sep 25 10:15:52 UTC 2018


On Tue, Sep 18, 2018 at 05:45:53PM +0200, Pavel Hrdina wrote:
>They all need virCgroupV1GetMemoryUnlimitedKB() so it's easier to
>move them in one commit.
>
>Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>---
> src/util/vircgroup.c        | 128 ++-------------------------
> src/util/vircgroupbackend.h |  30 +++++++
> src/util/vircgrouppriv.h    |   6 ++
> src/util/vircgroupv1.c      | 168 ++++++++++++++++++++++++++++++++++++
> 4 files changed, 211 insertions(+), 121 deletions(-)
>
>diff --git a/src/util/vircgroupbackend.h b/src/util/vircgroupbackend.h
>index 672fb082c1..5e75e495c3 100644
>--- a/src/util/vircgroupbackend.h
>+++ b/src/util/vircgroupbackend.h
>@@ -219,6 +219,30 @@ typedef int
> (*virCgroupGetMemoryUsageCB)(virCgroupPtr group,
>                              unsigned long *kb);
>
>+typedef int
>+(*virCgroupSetMemoryHardLimitCB)(virCgroupPtr group,
>+                                 unsigned long long kb);
>+
>+typedef int
>+(*virCgroupGetMemoryHardLimitCB)(virCgroupPtr group,
>+                                 unsigned long long *kb);
>+
>+typedef int
>+(*virCgroupSetMemorySoftLimitCB)(virCgroupPtr group,
>+                                 unsigned long long kb);
>+
>+typedef int
>+(*virCgroupGetMemorySoftLimitCB)(virCgroupPtr group,
>+                                 unsigned long long *kb);
>+
>+typedef int
>+(*virCgroupSetMemSwapHardLimitCB)(virCgroupPtr group,
>+                                  unsigned long long kb);
>+
>+typedef int
>+(*virCgroupGetMemSwapHardLimitCB)(virCgroupPtr group,
>+                                  unsigned long long *kb);
>+
> struct _virCgroupBackend {
>     virCgroupBackendType type;
>

There are just two different types here.

Regardless:
Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180925/9669ef7f/attachment-0001.sig>


More information about the libvir-list mailing list