[libvirt] [PATCH v2 5/5] qemu: Avoid duplicate resume events and state changes
John Ferlan
jferlan at redhat.com
Tue Sep 25 15:05:28 UTC 2018
On 9/25/18 9:19 AM, Jiri Denemark wrote:
> The only place where VIR_DOMAIN_EVENT_RESUMED should be generated is the
> RESUME event handler to make sure we don't generate duplicate events or
> state changes. In the worse case the duplicity can revert or cover
> changes done by other event handlers.
>
> For example, after QEMU sent RESUME, BLOCK_IO_ERROR, and STOP events
> we could happily mark the domain as running and report
> VIR_DOMAIN_EVENT_RESUMED to registered clients.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1612943
>
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>
> Notes:
> Version 2:
> - keep VIR_DOMAIN_EVENT_RESUMED_MIGRATED event at the end of post-copy
> migration
>
> src/qemu/qemu_driver.c | 13 -----------
> src/qemu/qemu_migration.c | 49 ++++++++++++++++-----------------------
> src/qemu/qemu_process.c | 10 ++++----
> 3 files changed, 24 insertions(+), 48 deletions(-)
>
This resolves the issue I noted, so
Reviewed-by: John Ferlan <jferlan at redhat.com>
John
More information about the libvir-list
mailing list