[libvirt] [PATCH] Revert "vircgroup: cleanup controllers not managed by systemd on error"

Fabiano Fidêncio fidencio at redhat.com
Thu Sep 27 14:32:37 UTC 2018


On Thu, 2018-09-27 at 16:13 +0200, Pavel Hrdina wrote:
> This reverts commit 1602aa28f820ada66f707cef3e536e8572fbda1e.
> 
> There is no need to call virCgroupRemove() nor virCgroupFree() if
> virCgroupEnableMissingControllers() fails because it will not modify
> 'group' at all.  The cleanup is done in virCgroupMakeGroup().

I wouldn't mention "The cleanup is done in virCGroupMakeGroup() because
there's no cleanup needed from virCgroupEnableMissingControllers() as
groups is only modified in case of success.

I'd wait for John's ACK as well, but:
Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>




More information about the libvir-list mailing list