[libvirt] [PATCH v3 0/6] BaselineHypervisorCPU using QEMU QMP exchanges

Chris Venteicher cventeic at redhat.com
Thu Sep 27 21:26:39 UTC 2018


Some architectures (S390) depend on QEMU to compute baseline CPU model and
expand a models feature set.

Interacting with QEMU requires starting the QEMU process and completing one or
more query-cpu-model-baseline QMP exchanges with QEMU in addition to a
query-cpu-model-expansion QMP exchange to expand all features in the model.

See "s390x CPU models: exposing features" patch set on Qemu-devel for discussion
of QEMU aspects.

This is part of resolution of: https://bugzilla.redhat.com/show_bug.cgi?id=1511999

Version 3 attempts to address all issues from V1 and V2 including making the 
QEMU process activation for QMP Queries generic (not specific to capabilities)
and moving that code from qemu_capabilities to qemu_process. 

I attempted to make the new qemu_process functions consistent with the functions
but mostly ended up reusing the guts of the previous functions from qemu_capabilities.

Of interest may be the choice to reuse a domain structure to hold the Qmp Query
process state and connection information.  Also, pay attention to the use of a large
random number to uniquely identify decoupled processes in terms of sockets and
file system footprint.  If you believe it's worth the effort I think there are some
pre-existing library functions to establish files with unique identifiers in a
thread safe way.

The last patch may also be interesting and is based on past discussion of QEMU cpu
expansion only returning migratable features except for one x86 case where
non-migratable features are explicitly requested.  The patch records that features
are migratable based on QEMU only returning migratable features.  The main result
is the CPU xml for S390 CPU's contains the same migratability info the X86 currently
does.  The testcases were updated to reflect the change.  Is this ok?  

Unlike the previous versions every patch should compile independently if applied
in sequence.

Thanks,
Chris


Chris Venteicher (6):
  qemu_monitor: Introduce qemuMonitorCPUModelInfoNew
  qemu_monitor: Introduce qemuMonitorCPUModelInfo / JSON conversion
  qemu_monitor: qemuMonitorGetCPUModelExpansion inputs and outputs
    CPUModelInfo
  qemu_process: Use common processes mgmt funcs for all QMP query types
  qemu_driver: BaselineHypervisorCPU support for S390
  qemu_monitor: Default props to migratable when expanding cpu model

 src/qemu/qemu_capabilities.c                  | 559 ++++++++----------
 src/qemu/qemu_capabilities.h                  |   4 +
 src/qemu/qemu_driver.c                        | 143 ++++-
 src/qemu/qemu_monitor.c                       | 199 ++++++-
 src/qemu/qemu_monitor.h                       |  29 +-
 src/qemu/qemu_monitor_json.c                  | 210 +++++--
 src/qemu/qemu_monitor_json.h                  |  13 +-
 src/qemu/qemu_process.c                       | 398 +++++++++++++
 src/qemu/qemu_process.h                       |  35 ++
 tests/cputest.c                               |  11 +-
 .../caps_2.10.0.s390x.xml                     |  60 +-
 .../caps_2.11.0.s390x.xml                     |  58 +-
 .../caps_2.12.0.s390x.xml                     |  56 +-
 .../qemucapabilitiesdata/caps_2.8.0.s390x.xml |  32 +-
 .../qemucapabilitiesdata/caps_2.9.0.s390x.xml |  34 +-
 .../qemucapabilitiesdata/caps_3.0.0.s390x.xml |  64 +-
 tests/qemucapabilitiestest.c                  |   7 +
 17 files changed, 1375 insertions(+), 537 deletions(-)

-- 
2.17.1




More information about the libvir-list mailing list