[libvirt] [PATCH v3 4/6] travis: use declarative syntax for homebrew packages

Andrea Bolognani abologna at redhat.com
Mon Apr 1 08:08:45 UTC 2019


On Wed, 2019-03-27 at 17:10 +0000, Daniel P. Berrangé wrote:
> Instead of running custom commands use the new declarative syntax for
> listing extra homebrew packages.

s/homebrew/Homebrew/g in the commit message.

[...]
> +addons:
> +  homebrew:
> +    packages:
> +      - ccache
> +      - rpcgen
> +      - xz
> +      - yajl

According to the documentation[1], this is not equivalent to the
code you're replacing since it will not run 'brew update' before
installing packages. Updating the system before building sounds
like a good idea to me, but I could be convinced otherwise :)

Another thing I think is worth mentioning is that several times in
the past we had to work around Homebrew issues, which is easy to do
when you're calling it from the shell but not so when you use the
declarative syntax. Switching back and forth is simple enough,
though, so we can just do that if the need ever arises again.


[1] https://docs.travis-ci.com/user/installing-dependencies/#installing-packages-on-macos

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list