[libvirt] [PATCH] qemu: fix domain unlock/unref in qemuMigrationSrcPerform

Nikolay Shirokovskiy nshirokovskiy at virtuozzo.com
Mon Apr 1 10:03:00 UTC 2019


qemuMigrationSrcPerform callers expect it to call virDomainObjEndAPI
in any case.

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy at virtuozzo.com>
---
 src/qemu/qemu_migration.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 419a729..ce4c443 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -4799,6 +4799,7 @@ qemuMigrationSrcPerform(virQEMUDriverPtr driver,
         if (cookieinlen) {
             virReportError(VIR_ERR_OPERATION_INVALID,
                            "%s", _("received unexpected cookie with P2P migration"));
+            virDomainObjEndAPI(&vm);
             return -1;
         }
 
@@ -4813,6 +4814,7 @@ qemuMigrationSrcPerform(virQEMUDriverPtr driver,
         if (dconnuri) {
             virReportError(VIR_ERR_INTERNAL_ERROR,
                            "%s", _("Unexpected dconnuri parameter with non-peer2peer migration"));
+            virDomainObjEndAPI(&vm);
             return -1;
         }
 
-- 
1.8.3.1




More information about the libvir-list mailing list