[libvirt] [PATCH 07/10] qemu: Use VIR_TMP to stop leaking pointer to VNC password pointer to stack

Peter Krempa pkrempa at redhat.com
Mon Apr 1 13:04:58 UTC 2019


Spare a few cpu cycles to allow us feeling a bit better about ourselves.
---
 src/qemu/qemu_hotplug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 4e94d80f21..7f46b1fd9f 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -4210,7 +4210,7 @@ qemuDomainChangeGraphicsPasswords(virQEMUDriverPtr driver,
     const char *expire;
     char *validTo = NULL;
     const char *connected = NULL;
-    const char *password;
+    VIR_TMP(const char *) password;
     int ret = -1;
     virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);

-- 
2.20.1




More information about the libvir-list mailing list