[libvirt] [PATCH v2] qemu: fix domain unlock/unref in qemuMigrationSrcPerform
Michal Privoznik
mprivozn at redhat.com
Mon Apr 1 13:59:50 UTC 2019
On 4/1/19 3:28 PM, Nikolay Shirokovskiy wrote:
> qemuMigrationSrcPerform callers expect it to call virDomainObjEndAPI
> in any case so on error paths we miss the virDomainObjEndAPI call.
> To fix this let's make qemuMigrationSrcPerform callers responsible
> for the virDomainObjEndAPI call.
>
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy at virtuozzo.com>
> ---
>
> diff to v1 [1]:
> - move virDomainObjEndAPI call to qemuMigrationSrcPerform callers
>
> [1] https://www.redhat.com/archives/libvir-list/2019-April/msg00032.html
>
> src/qemu/qemu_driver.c | 21 +++++++++------------
> src/qemu/qemu_migration.c | 2 --
> 2 files changed, 9 insertions(+), 14 deletions(-)
ACK. I'll let Jirka chime in to decide if this is worth merging into
5.2.0 or wait for 5.3.0. Jirka?
Michal
More information about the libvir-list
mailing list