[libvirt] [PATCH] virsh: cmdConsole: make --domain optional

Eric Blake eblake at redhat.com
Mon Apr 1 19:27:38 UTC 2019


On 4/1/19 2:04 PM, Ján Tomko wrote:
> In the absence of a domain parameter, console the user instead.
> 
> Signed-off-by: Ján Tomko <jtomko at redhat.com>
> ---
>  tools/virsh-domain.c | 25 ++++++++++++++++++++++++-
>  1 file changed, 24 insertions(+), 1 deletion(-)

Missing doc updates to virsh.pod. How is a user going to know they can
be consoled?


> +static const char *
> +constellation_phrases[] = {

s/constellation/consolation/ ?

> +    "Everything is going to be all right.",
> +    "Things are going to work out in the end.",
> +    "Imagine pleasant nonsense", /* https://www.instagram.com/p/BuRfmkrBigI/ */
> +    "Ursa Major",

except that you did mix in a constellation phrase.  Hmm.  Now I'm going
to have to run this command to resolve the confusion that has arisen in
my mind...

> +    "There, there.",
> +};
> +


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190401/9e3e7b64/attachment-0001.sig>


More information about the libvir-list mailing list