[libvirt] [PATCHv2 12/14] virjsondata: json_reformat input data

Peter Krempa pkrempa at redhat.com
Wed Apr 3 09:19:23 UTC 2019


On Tue, Apr 02, 2019 at 17:41:51 +0200, Ján Tomko wrote:
> Remove trailing slashes and run json_reformat.
> 
> Signed-off-by: Ján Tomko <jtomko at redhat.com>
> ---
>  tests/virjsondata/parse-Harder-in.json      |  17 +-
>  tests/virjsondata/parse-NotSoSimple-in.json |  18 ++-
>  tests/virjsondata/parse-Simple-in.json      |   7 +-
>  tests/virjsondata/parse-VeryHard-in.json    | 167 +++++++++++++++++---
>  4 files changed, 177 insertions(+), 32 deletions(-)

I don't think we should do this for the input files and even for some
output files. The non-prettified input/output is used in QMP monitor
interactions and I think we should keep at least some in the "native"
format.

This is to complement most other test files like the caps replies where
we use the prettified output so that the files can be updated
reasonably. This static data does not have to change.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190403/67a7c89a/attachment-0001.sig>


More information about the libvir-list mailing list