[libvirt] [python PATCH] rpm: use new python macros for build/install rules

Andrea Bolognani abologna at redhat.com
Thu Apr 4 10:18:39 UTC 2019


On Wed, 2019-04-03 at 18:11 +0100, Daniel P. Berrangé wrote:
[...]
>  %if %{with_python2}
> +%if 0%{?fedora} >= 29 || 0%{?rhel} >= 8
> +%py2_build
> +%else

So based on this it looks like the %py*_build macros were only
introduced in Fedora 29...

>  %if %{with_python2}
> +%if 0%{?fedora} || 0%{?rhel} >= 8
> +%py2_install
> +%else

... but based on this it seems like the %py*_install macros were
already present in Fedora 28?

Looking at my Fedora 28 guest, more specifically in

  /usr/lib/rpm/macros.d/macros.python*

I see the %py*_build macros, so I guess the latter version is the
correct one.

Once you've removed the bogus '>= 29's,

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list