[libvirt] [PATCH 0/3] Remove website search, just use google

Cole Robinson crobinso at redhat.com
Thu Apr 4 14:18:03 UTC 2019


On 4/4/19 4:25 AM, Andrea Bolognani wrote:
> On Wed, 2019-04-03 at 18:26 -0400, Cole Robinson wrote:
>> Andrea's ChangeLog patches reminder me that I attempted something
>> similarish once, and also tried to drop our custom website search:
>>
>> http://www.redhat.com/archives/libvir-list/2016-May/msg01616.html
> 
> Glad to be an inspiration for you! :)
> 
>> danpb recommended I just make our search bar use google instead but
>> I never made the attempt. 3 years later here it is.
>>
>> Patch #1 makes the switch but doesn't remove anything
>>
>> Patch #2 drops index.py, the search indexer
>>
>> Patch #3 drops search.php and all the references to it.
>>     libvirt.org/search.php is still a valid URL so this may break some
>>     links, even though at the moment the page prints virtually nothing
>>     except some boilerplate text. Maybe we can redirect it to the
>>     homepage or something, ideas welcome
> 
> I like the idea, and I like the diffstat even more O:-)
> 
> I would, however, suggest a slightly different implementation than
> what you have here, where using the search bar would still send you
> to https://libvirt.org/search.php?query=X, and that page would
> contain three links:
> 
>   * "Search libvirt.org"
>     https://google.com/search?q=site:libvirt.org+X
> 
>   * "Search the libvirt wiki"
>     https://wiki.libvirt.org/index.php?search=X
> 
>   * "Search the libvir-list mailing list archives"
>     https://google.com/search?q=site:redhat.com/archives/libvir-list+X
> 
> The advantages of this approach are that existing links pointing to
> search.php will keep working, people will be able to search the
> mailing list archives as well (this is a feature the current search
> implementation is supposed to have) and search the wiki without
> having to go through an extra hoop, and finally that extending the
> search interface to include more sources would become as simple as
> adding another generated link to the page.
> 

No objections from me but considering the embarassingly long time it
took me to even get this solution working, I shouldn't be the one to
implement it!

Unless someone volunteers in the short term I think patch #1 and #2 can
still go in, and search.php can be removed/replaced with the proper fix

Thanks,
Cole




More information about the libvir-list mailing list