[libvirt] [PATCH 0/5] examples: enforce compiler warning flags
Ján Tomko
jtomko at redhat.com
Fri Apr 5 14:13:16 UTC 2019
On Tue, Apr 02, 2019 at 11:02:06AM +0100, Daniel P. Berrangé wrote:
>The example programs emitted a number of warnings even without having
>the WARN_CFLAGS set. Once they were set a bunch more flaws came to
>light. Fix them all and enforce warnings so that the example programs
>are higher quality code.
>
>Daniel P. Berrangé (5):
> examples: fix 64-bit integer formatting on Windows
> examples: avoid goto jump over initialization of variable
> domtop: remove unused domain name parameter
> dominfo: make example more useful
> examples: enable all compiler warnings
>
> examples/Makefile.am | 3 ++-
> examples/admin/client_info.c | 7 ++++---
> examples/admin/client_limits.c | 2 +-
> examples/admin/list_clients.c | 3 ++-
> examples/admin/threadpool_params.c | 2 +-
> examples/dominfo/info1.c | 25 ++++++++++++++-----------
> examples/domtop/domtop.c | 13 ++++++++-----
> 7 files changed, 32 insertions(+), 23 deletions(-)
>
Reviewed-by: Ján Tomko <jtomko at redhat.com>
Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190405/4f6a0753/attachment-0001.sig>
More information about the libvir-list
mailing list